[BUG] Local testing using optional dicts with optional values does not work #3294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-e Signed-off-by: machichima <[email protected]>
-e Signed-off-by: machichima <[email protected]>
-e Signed-off-by: machichima <[email protected]>
-e Signed-off-by: machichima <[email protected]>
-e Signed-off-by: machichima <[email protected]>
-e Signed-off-by: machichima <[email protected]>
-e Signed-off-by: machichima <[email protected]>
-e Signed-off-by: machichima <[email protected]>
machichima
requested review from
cosmicBboy,
davidmirror-ops,
eapolinario,
kumare3,
pingsutw,
samhita-alla and
wild-endeavor
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3294 +/- ##
==========================================
+ Coverage 76.42% 76.59% +0.16%
==========================================
Files 215 215
Lines 22545 22548 +3
Branches 2969 2969
==========================================
+ Hits 17230 17270 +40
+ Misses 4498 4474 -24
+ Partials 817 804 -13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kumare3
approved these changes
Jul 13, 2025
kumare3
approved these changes
Jul 14, 2025
Contributor
|
I tested it looks good, thank you |
Atharva1723
pushed a commit
to Atharva1723/flytekit
that referenced
this pull request
Oct 5, 2025
…t work (flyteorg#3294) Signed-off-by: machichima <[email protected]> Signed-off-by: Atharva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes flyteorg/flyte#6474
Why are the changes needed?
When running task locally, using optional list values types (i.e.
dict[str, list[str] | None] | None) will cause error. However, when running such task on the cluster it worksWhat changes were proposed in this pull request?
Error occurs when we call
_are_types_castable(List[Sample], Union). In original code, the check for collection type will directly returnFalse, which indicates thatList[Sample]is not castable toUnion[List[Sample], None], leading to the error.In this PR, I deal with
union_typefirst in_are_types_castablefunction to overcome this problem.How was this patch tested?
Test with the following script. See result in Screenshots section.
Setup process
Screenshots
Successfully execute the above script:
Check all the applicable boxes
Related PRs
Docs link
Summary by Bito
This pull request fixes a bug in type casting for optional dictionary values, ensuring the `_are_types_castable` function properly handles union types. It also includes minor code cleanup to enhance error handling in type transformations.